Skip to content

Fix deprecation warning: LICENSE is autodetected #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbieber merged 1 commit into from
Feb 1, 2023
Merged

Fix deprecation warning: LICENSE is autodetected #434

dbieber merged 1 commit into from
Feb 1, 2023

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 1, 2023

This can be omitted entirely because setuptools automatically includes LICENSE:

A list of glob patterns for license related files that should be included. If neither license_file nor license_files is specified, this option defaults to LICEN[CS]E*, COPYING*, NOTICE*, and AUTHORS*.

https://setuptools.pypa.io/en/latest/references/keywords.html#keywords

Before

$ python setup.py --licence
/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/setuptools/dist.py:775: UserWarning: Usage of dash-separated 'license-file' will not be supported in future versions. Please use the underscore name 'license_file' instead
  warnings.warn(
/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/setuptools/config/setupcfg.py:520: SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.
  warnings.warn(msg, warning_class)
Apache Software License

After

$ python setup.py --licence
Apache Software License

@hugovk hugovk mentioned this pull request Feb 1, 2023
Closed
@dbieber dbieber merged commit 0438367 into google:master Feb 1, 2023
@hugovk hugovk deleted the fix-licence-deprecation branch February 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @dbieber