Skip to content

Conversation

@alissonlauffer
Copy link
Member

Description

Currently, the filename was being created from the suffix of the temp filename, thus leading to the file always be called .temp. This fixes it and also does the reverse: It now creates the temp filename from the actual filename, which feels better to me.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

currently, the filename was being created from the temp filename
@alissonlauffer alissonlauffer merged commit ab59bfa into main Dec 3, 2023
@HitaloM HitaloM deleted the fix/fix-handle-download branch December 3, 2023 20:11
@HitaloM HitaloM added the bug Something is wrong label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants