Skip to content

Conversation

@alissonlauffer
Copy link
Member

@alissonlauffer alissonlauffer commented Dec 4, 2023

Description

This PR fixes two issues, one caused by a typo where a Path(audio).is_file() (bool) was passed to file_name in send_audio.py. The other was caused by closing the BytesIO object prematurely, making the returned BytesIO object unreadable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Member

@HitaloM HitaloM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and fixes the issue. You can merge the pull request.

Copy link
Member

@usernein usernein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alissonlauffer alissonlauffer merged commit a6c5630 into main Dec 4, 2023
@alissonlauffer alissonlauffer deleted the hotfix/fix-audio-sending-and-file-downloading branch December 4, 2023 17:53
@HitaloM HitaloM added the bug Something is wrong label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants