Make mutations optional #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks so much for the PR! Sorry it took a bit to respond. I'm going to take a look at this next week. Seems like a great idea. I wonder if it should still be the default to mutate though, and instead allow a flag to not mutate. I'll have to think about it for a bit. |
Owner
|
Sorry for the delay! I love the idea but wanted to implement it in a slightly different fashion. There is a new Closing this in favor of that. Thank you for the idea and inspiration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
-mflag optional. I think it's useful to allow this to be empty for quick scans.