Skip to content

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented May 3, 2024

Motivation

I updated our copilot-local repo to the latest upstream commit, and it did not work against LocalStack any more. I am not 100% sure the current commit works either.

The initial failure reason was our StackSet support in CloudFormation.

Changes

  • Update get_template_body to allow use of the previous stack (UsePreviousStack)
  • Expand on the StackSet entity mostly allowing access to the template body for use by StackInstances
  • Look up stack sets when retrieving template summaries
  • Merge StackInstance parameter overrides with StackSet parameter definitions
  • Introduce convert_in_place_at_jsonpath for deep nested structure in place type conversion
  • Expand on test_create_stack_set_with_stack_instances test to support parameter overrides

Testing

I have been testing with my fork of copilot-local which has a few changes to the LocalStack fork of copilot:

  • the localstack branch has been rebased onto the latest tagged release (v1.33.3 at the time of writing)
  • the manifest parsing has been improved to correctly handle escaped newlines, which cause invalid yaml parsing

As of 2024-06-07 I had not yet completed the work required to fix copilot-local. I think I was close, but not there yet.

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 3, 2024
@simonrw simonrw self-assigned this May 3, 2024
@github-actions
Copy link

github-actions bot commented May 3, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 35m 55s ⏱️ + 1m 7s
3 028 tests ±0  2 693 ✅ ±0  335 💤 ±0  0 ❌ ±0 
3 030 runs  ±0  2 693 ✅ ±0  337 💤 ±0  0 ❌ ±0 

Results for commit 9424427. ± Comparison against base commit 2f05d65.

♻️ This comment has been updated with latest results.

@simonrw simonrw changed the title Improve stack set support CFn: Improve stack set support May 22, 2024
@simonrw simonrw force-pushed the cfn/stacksets branch 2 times, most recently from 51d92c2 to 9424427 Compare June 7, 2024 19:59
@joe4dev joe4dev added this to the Playground milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants