SQS - updating queues before saving a snapshot #13485
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
added
area: persistence
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 33m 7s ⏱️ Results for commit 347c56d. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 5m 53s ⏱️ Results for commit 347c56d. |
giograno
added
the
semver: patch
baermat
approved these changes
Dec 10, 2025
Member
baermat
left a comment
baermat
left a comment
There was a problem hiding this comment.
Change looks good to me! Would be nice if we either have a persistence test, or at least a manual confirmation that this does what we are expecting and is not causing any unexpected problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Whenever we save an SQS state, we should avoid snapshotting expired messages.
We have seen reports from users claiming that the saved states contain messages that should have been cleared.
Closes PNX-548
Changes
do_update_all_queues. This should trigger the deletion of expired messages. Since I am not very familiar with the service internals, I am not 100% sure we can use any other internal API to do the same.