use OUTBOUND_HTTP_PROXY for for external bypass client #13565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 7m 54s ⏱️ Results for commit c4aaa55. |
cloutierMat
added
semver: patch
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 35m 15s ⏱️ Results for commit c4aaa55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When creating an
ExternalBypassDnsClient, we should remain mindful of users proxy configurations and ensure that those external calls are respecting the Outbound Proxy configuration.Changes
Ensure both the client and the http session are created with the user's http proxy configuration.
Tests
OUTBOUND_HTTP_PROXYandOUTBOUND_HTTPS_PROXYset to your proxies, configuration. It might be required also to setREQUESTS_CA_BUNDLE.Related
fixes UNC-146