Alternative for the ReferencedAccessibilityTest #3525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing anymore, but instead use behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the test does not use the target property warning mechanism to check if a mapping did not take place, but instead checks if the resulting field is filled or not.
2 reasons why I want to change this:
The first reason is that a change in the property message should not result in this test failing.
The second reason would be traceability for when a bug appears.
If a bug would be introduced with the following symptoms:
These tests would then still pass, while this sounds to me like a failure situation for this test class.
Created this PR to continue the discussion started at #3522