#3133 Redundant null check in generated code when adding parameters #3583
+194
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
2 times, most recently
from
0b95442 to
464cc8b
Compare
zyberzebra
commented
Apr 29, 2024
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Show resolved
Hide resolved
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
from
9bc9826 to
82f7835
Compare
Contributor
Author
|
Somthing must be configured incorrectly in my IDE... I'm not sure why though |
filiphr
reviewed
Sep 6, 2024
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Nice work @zyberzebra. I've done some small polishing (see my commits). Let me know if I've removed too much.
Can you please also rebase this on top of main?
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Outdated
Show resolved
Hide resolved
- verify redundant null checks in mappings are avoided - targets mapper methods that involve update mappings and ensures that null checks are not applied redundantly if already covered - tests for multiple scenarios
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
from
aa7bca2 to
0d1561f
Compare
daniele-tavernelli-moveax
pushed a commit
to tn-aixpa/aixfc
that referenced
this pull request
Jul 25, 2025
Contributor
Author
|
@filiphr Is just a rebase needed again? |
Member
|
Not sure what the problem is @zyberzebra, the logs from the builds are gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for: #3133