Handle single color for multiple datasets in hist
#30867
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The code itself is fine. Please update the docstring and ad a release note. See https://matplotlib.org/devdocs/devel/api_changes.html#announce-new-and-deprecated-api. |
Contributor
Author
|
Done. @timhoffm |
timhoffm
reviewed
Dec 17, 2025
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Sorry, I forgot to mention: Could you please also add a test?
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Contributor
Author
|
I have add a new test for hist and update the what's news. |
timhoffm
reviewed
Dec 18, 2025
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Close #30857 with minimal change
If a single valid color is provided, duplicate it to match the size of the dataset.
PR checklist