Fixed mapped type modifier propagation when remapping multiple keys to same property #62927
+470
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where mapped types with key remapping would produce inconsistent modifier propagation when multiple keys remapped to the same output property name. The behavior was dependent on the order of keys in the source type, which was incorrect.
Key changes:
- Added logic to merge optional and readonly modifiers when multiple source keys map to the same target property in mapped types
- Added comprehensive test coverage for both optional and readonly modifier merging scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/compiler/checker.ts |
Added logic in addMemberForKeyTypeWorker to merge modifiers (optional/readonly) when an existing property is encountered during mapped type key remapping |
tests/cases/compiler/mappedTypeRemappingModifierMerging.ts |
New test case verifying consistent modifier propagation when multiple keys remap to the same property, testing both optional and readonly modifiers |
tests/baselines/reference/mappedTypeRemappingModifierMerging.types |
Baseline file showing expected type inference for the new test |
tests/baselines/reference/mappedTypeRemappingModifierMerging.symbols |
Baseline file showing expected symbol resolution for the new test |
tests/baselines/reference/mappedTypeRemappingModifierMerging.js |
Baseline file showing expected JavaScript output and declaration files |
tests/baselines/reference/mappedTypeRemappingModifierMerging.errors.txt |
Baseline file showing expected readonly property assignment errors |
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62318