Skip to content

Corebot 101 initial checkin #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daveta merged 2 commits into from
Jul 10, 2019
Merged

Corebot 101 initial checkin #245

daveta merged 2 commits into from
Jul 10, 2019

Conversation

@daveta
Copy link
Contributor

@daveta daveta commented Jul 9, 2019

101.CoreBot-BertBiDAF sample

Corebot using alternate language understanding models (BERT/BiDAF).

  • Demonstrates how to perform inferences inside the bot process and using external REST API.
  • Demonstrate training (and inferencing) from Jupyter Lab notebooks.
  • Demonstrate how to run in Docker containers.

Please run and let me know if you run into issues.

tsuwandy
tsuwandy approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@Zerryth
Copy link
Contributor

Zerryth commented Jul 10, 2019 •
edited
Loading

I have to get going to an optometrist appointment right now, however got through most of what the README instructed, with everything working so far! (Made a few minor tweaks to README)

Anyways, late tonight I'll go through the Docker portion as a Docker noob, after appointments

@Zerryth
Copy link
Contributor

Zerryth commented Jul 10, 2019 •
edited
Loading

@daveta just got home and started building docker container.

Everything looked fine until I got to the step in the bot where it should be recognizing entities, unfortunately. I'll drop by tomorrow morning to see what's wrong--it could most definitely be a user error:

Emulator:
image

Running docker ps
image

Terminal where I run bot:
image

@daveta
Copy link
Contributor Author

daveta commented Jul 10, 2019

@Zerryth : Awesome! The specific error you are getting suggests that the bot cannot connect to the model runtime service endpoint. You appear to be using the right hostname so the container is having issues resolving, let's sync up in the morning.

Zerryth
Zerryth approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@Zerryth Zerryth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through with Dave in the morning and got through making the containers work. Pushed edits to README and now it's all good to go! :)

@daveta daveta merged commit 34988a8 into master Jul 10, 2019
@daveta daveta deleted the daveta-core101 branch July 10, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axelsrz axelsrz Awaiting requested review from axelsrz

@CezaryMarcjan CezaryMarcjan Awaiting requested review from CezaryMarcjan

@scheyal scheyal Awaiting requested review from scheyal

2 more reviewers

@tsuwandy tsuwandy tsuwandy approved these changes

@Zerryth Zerryth Zerryth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daveta @Zerryth @tsuwandy