Skip to content

Fix/ai search copy all #284498 #285056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eidriahn wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/ai search copy all #284498 #285056

eidriahn wants to merge 3 commits into from
+29 −5

Conversation

@eidriahn
Copy link

@eidriahn eidriahn commented Dec 25, 2025

Fixes issue #284498

The issue was caused by the fact that the copyAllCommand wasn't considering whether the click was done on normal searches or ai searches.

Test it:

  • Go to search -> AI Search
  • Search for anything
  • Right click on any result and select 'Copy All'
  • Paste the copied contents into a file and check if they correspond.

Copilot AI review requested due to automatic review settings December 25, 2025 20:48
@eidriahn
Copy link
Author

eidriahn commented Dec 25, 2025

@eidriahn please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copilot AI reviewed Dec 25, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #284498 where the "Copy All" command in search results was not distinguishing between normal search results and AI search results. The fix enables the command to copy only the relevant type of results based on the context of the clicked element.

Key Changes

  • Modified copyAllCommand to accept a match parameter to determine the context of the action
  • Added isAISearchResult helper function to determine if a clicked element belongs to AI search results
  • Updated the call to root.folderMatches() to pass the AI flag based on the clicked element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@osortega osortega

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eidriahn @osortega