-
Notifications
You must be signed in to change notification settings - Fork 173
Improve packer unpacker performance #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce byte array based unpacker. * Refactor with bridge pattern to support ByteArrayUnpacker as well as improve code sharing for maintenancibility, runtime working set size, and dll size. * Experimentally introduce "Fast" unpacker which does not bookkeep collection state. * Improve ext type unpacking efficiency.
* Stream position and sentinel check always fail for non-stream based Unpacker. * Fast unpacker does not check subtree state, so these tests should be skipped.
…ed unpacker tests.
This commit introduce byte array based packer for performance by avoiding Stream operation. This commit also includes: * Factory methods for byte array packers. * Internal buffer managers to support various use cases for byte array packers. * Encoder extension method for efficient encoding. * Refactoring to reuse msgpack packing logic amang flavors.
This commit also enable unsafe option for future use.
This commit ensures at least 4 bytes remains in the buffer for utf8 encoding.
This commit unifies and inlines packer impls to MessagePackXxxPacker.
This commit inlines over structured unpacker hierarchy to reduce virtcall and code size. This commit also improves offset management for "stripped" Stream.
…ows InvalidMessageStreamException for EoF. The methods' contracts do not state throwing InvalidMessageStreamException in the first place.
Latest Unity does not allow System.Web and System.Windows.Forms assembly reference, so this commit excludes them from net3.5 build.
For platforms which do not support TraceSource, the tracing code is nop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add byte array based packer/unpacker and efficient (but not precise) subtree unpacker.
This PR also includes some bug fixes found in testing.