ceiling_dirs parameter in Repository.discover is optional
#1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcjsuen
force-pushed
the
optional-discover
branch
from
72c5c1e to
98c7102
Compare
rcjsuen
force-pushed
the
optional-discover
branch
from
98c7102 to
088ae83
Compare
libgit2's git_repository_discover function's ceiling_dirs parameter can be null. Flag the parameter as such in the JSON file so that the NodeGit wrapper API behaves the same way. Signed-off-by: Remy Suen <remy.suen@gmail.com>
rcjsuen
force-pushed
the
optional-discover
branch
from
088ae83 to
0f53a51
Compare
Member
Author
|
Do I need to do anything else to get this merged in? |
Member
|
just gotta bring it to my attention, again 😄. |
Member
Author
|
@implausible Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2's
git_repository_discoverfunction has an optionalceiling_dirsparameter. We should flag it as such in our JSON file.