Support signing in Repository#mergeBranches #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implausible
requested changes
Apr 17, 2019
| let toBranch; | ||
| processMergeMessageCallback = processMergeMessageCallback || | ||
| // Support old parameter `processMergeMessageCallback` | ||
| const isOldOptionParameter = typeof mergeBranchOptions === "function"; |
Member
There was a problem hiding this comment.
Can you output a console.error warning that this parameter is deprecated and should be updated to the new object type?
Member
There was a problem hiding this comment.
Any tests that use this method should also be updated to use the new parameter format.
ianhattendorf
force-pushed
the
fix/repo-merge-sign
branch
from
c6dd470 to
17aca8c
Compare
implausible
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.