Skip to content

Conversation

@implausible
Copy link
Member

No description provided.

@implausible implausible changed the title Increase timeouts on failing tests Fix failing tests on CI Jul 22, 2019
@implausible implausible force-pushed the fix/test-instability branch from 3188259 to b5c2b28 Compare July 22, 2019 17:44
@implausible
Copy link
Member Author

Of course, add logging and the failures hide :(

These code paths usually work, but are randomly failing in Node 8 environments since we updated to NaN 2.14.0. We're going to skip these tests on Node 8, because the diagnosis is very tricky.

For the 3 rebase tests, as far as I can tell, they:
1. Get to rebase.commit
2. The signingCb gets called and completed
3. Freeze
4. The tests timeout
5. rebase.commit finishes executing and the rest of the promise chain completes.

Increasing the timeout did not help, and exhibited the same behavior, strangely enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant