Skip to content

Fix behaviour of Repository#getReferences #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
implausible merged 2 commits into from
Jul 25, 2019
Merged

Fix behaviour of Repository#getReferences #1708

implausible merged 2 commits into from
Jul 25, 2019

Conversation

@tiggerite
Copy link
Contributor

@tiggerite tiggerite commented Jul 25, 2019

Closes #1707 and properly filters out references by type.

implausible
implausible approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@implausible implausible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@implausible implausible merged commit de3d611 into nodegit:master Jul 25, 2019
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@implausible implausible implausible approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repository.getReferenceNames returns arrayReference, not arrayString

2 participants

@tiggerite @implausible