Skip to content

Added missing sshKeyMemoryNew to Cred #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zawata merged 1 commit into from
Dec 2, 2025
Merged

Added missing sshKeyMemoryNew to Cred #1973

zawata merged 1 commit into from
Dec 2, 2025

Conversation

@tkmcmaster
Copy link
Contributor

@tkmcmaster tkmcmaster commented Mar 3, 2023 •
edited
Loading

Closes #1962

While Git.Credential.sshKeyMemoryNew works, the deprecated Git.Cred is missing sshKeyMemoryNew breaking backwards compatibility.

import Git from "nodegit";

Object.keys(Git.Cred): ["defaultNew","sshKeyFromAgent","sshKeyNew","usernameNew","userpassPlaintextNew","TYPE"]

Object.keys(Git.Credential): ["defaultNew","sshKeyFromAgent","sshKeyMemoryNew","sshKeyNew","usernameNew","userpassPlaintextNew","getSelfFreeingInstanceCount","getNonSelfFreeingConstructedCount","TYPE"]

@tkmcmaster tkmcmaster mentioned this pull request Mar 3, 2023
Closed
@zawata zawata force-pushed the sshKeyMemoryNewDeprecated branch from f08a6f1 to 40f7fa9 Compare November 27, 2025 04:40
@zawata zawata self-assigned this Nov 27, 2025
@zawata zawata merged commit b556fd8 into nodegit:master Dec 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zawata zawata

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"sshKeyMemoryNew" is not found in Typescript

2 participants

@tkmcmaster @zawata