Skip to content

Conversation

@mmarchini
Copy link
Contributor

Since GitHub/Travis won't rerun tests for Pull Requests when master is updated, some commits landed after 85f067a, which made our linter test fail on `master. Also, since there are only a few open pull requests now, this is unlikely to happen again.

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files          34       34           
  Lines        4369     4369           
=======================================
  Hits         3549     3549           
  Misses        820      820
Impacted Files Coverage Δ
src/llscan.h 68.18% <ø> (ø) ⬆️
src/printer.cc 84.5% <ø> (ø) ⬆️
src/llscan.cc 60.73% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfbdca...53e3c02. Read the comment docs.

@mmarchini
Copy link
Contributor Author

cc @nodejs/llnode

mmarchini added a commit that referenced this pull request Mar 25, 2019
PR-URL: #276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mmarchini added a commit that referenced this pull request Mar 25, 2019
PR-URL: #276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mmarchini
Copy link
Contributor Author

Landed in ecfbdca...62ca523

@mmarchini mmarchini closed this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants