src: harden SlicedString::ToString #332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some extra checks to make sure we won't crash when stringifying a (possibly corrupted) SlicedString.
Contributor
Author
|
I had this issue in the wild. Couldn't come up with a test case for it though... |
cjihrig
approved these changes
Jan 16, 2020
mmarchini
added a commit
that referenced
this pull request
Jan 21, 2020
Add some extra checks to make sure we won't crash when stringifying a (possibly corrupted) SlicedString. PR-URL: #332 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in bff9f5e |
Pull Request Test Coverage Report for Build 6fa93812eafcac88c45bd0de0d399201c00e95af-PR-332Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some extra checks to make sure we won't crash when stringifying a
(possibly corrupted) SlicedString.