-
-
Notifications
You must be signed in to change notification settings - Fork 101
src: fix getopt format string #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We should add some testing here. Since we don't seem to have specific tests for command arguments, we can change one of the inspect tests: diff --git test/plugin/inspect-test.js test/plugin/inspect-test.js
index 0a59c9b..f664237 100644
--- test/plugin/inspect-test.js
+++ test/plugin/inspect-test.js
@@ -244,7 +244,7 @@ const hashMapTests = {
});
}, (t, sess, addresses, name, cb) => {
const address = addresses[name];
- sess.send(`v8 inspect --array-length 1 ${address}`);
+ sess.send(`v8 inspect -l 1 ${address}`);
sess.linesUntil(/\]>/, (err, lines) => {
if (err) return cb(err);We use Also our documentation is incomplete, |
|
I updated one of the tests. I should perhaps mention that I don't plan to spend much more time on this patch, I just sent it because I'm such a nice guy (and also because obvious bug is obvious.) |
|
Landed in 83c810f |
Pull Request Test Coverage Report for Build ba54c028a413aadad021bfa0db05d8700efc2eaf-PR-347Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build ba54c028a413aadad021bfa0db05d8700efc2eaf-PR-347Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
v8 inspect -l <n>takes an argument.Bug introduced in commit 2fc1571 ("src: option to limit output
of
findjsinstances") from September 2018.Fixes: #346