doc: fix supported version comment on README #356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
cjihrig
approved these changes
Apr 2, 2020
Contributor
Author
|
I don't think it should be a semver major since we dropped support before, but I understand if other folks feel otherwise. Also, the text is not entirely accurate, since v13 is not supported (and probably never will be). |
mmarchini
added a commit
that referenced
this pull request
Apr 3, 2020
Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: #356 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in fdddce0 |
mmarchini
added a commit
to mmarchini/llnode
that referenced
this pull request
Apr 27, 2020
Notable Changes: - Added support for Node.js v14 Commits: * [[`4918962bee`](nodejs@4918962bee)] - **build**: add v14 to the test matrix (Matheus Marchini) [nodejs#361](nodejs#361) * [[`c86eb4356c`](nodejs@c86eb4356c)] - **src**: update RegExp type constant for V8 8.1 (Matheus Marchini) [nodejs#361](nodejs#361) * [[`dd57bfb8af`](nodejs@dd57bfb8af)] - **src**: boxed double fields for V8 8.1 (Matheus Marchini) [nodejs#358](nodejs#358) * [[`fdddce0d2c`](nodejs@fdddce0d2c)] - **doc**: fix supported version comment on README (Matheus Marchini) [nodejs#356](nodejs#356) * [[`7b9598e9da`](nodejs@7b9598e9da)] - **tools**: git ignore core dumps (Matheus Marchini) [nodejs#308](nodejs#308) * [[`8e2a55c82e`](nodejs@8e2a55c82e)] - **src**: update SFI script accessor for V8 8.1 (Matheus Marchini) [nodejs#352](nodejs#352) * [[`364e034686`](nodejs@364e034686)] - **src**: fix some warnings and erroneous PRINT\_DEBUG (Matheus Marchini) [nodejs#354](nodejs#354) * [[`461e83aa0c`](nodejs@461e83aa0c)] - **src**: improve Error message on LoadPtr (Matheus Marchini) [nodejs#351](nodejs#351) * [[`1948512b5e`](nodejs@1948512b5e)] - **tools**: add script with commands to facilitate dev (Matheus Marchini) [nodejs#339](nodejs#339)
mmarchini
added a commit
that referenced
this pull request
May 4, 2020
Notable Changes: - Added support for Node.js v14 Commits: * [[`4918962bee`](4918962bee)] - **build**: add v14 to the test matrix (Matheus Marchini) [#361](#361) * [[`c86eb4356c`](c86eb4356c)] - **src**: update RegExp type constant for V8 8.1 (Matheus Marchini) [#361](#361) * [[`dd57bfb8af`](dd57bfb8af)] - **src**: boxed double fields for V8 8.1 (Matheus Marchini) [#358](#358) * [[`fdddce0d2c`](fdddce0d2c)] - **doc**: fix supported version comment on README (Matheus Marchini) [#356](#356) * [[`7b9598e9da`](7b9598e9da)] - **tools**: git ignore core dumps (Matheus Marchini) [#308](#308) * [[`8e2a55c82e`](8e2a55c82e)] - **src**: update SFI script accessor for V8 8.1 (Matheus Marchini) [#352](#352) * [[`364e034686`](364e034686)] - **src**: fix some warnings and erroneous PRINT\_DEBUG (Matheus Marchini) [#354](#354) * [[`461e83aa0c`](461e83aa0c)] - **src**: improve Error message on LoadPtr (Matheus Marchini) [#351](#351) * [[`1948512b5e`](1948512b5e)] - **tools**: add script with commands to facilitate dev (Matheus Marchini) [#339](#339) PR-URL: #363
Pull Request Test Coverage Report for Build 2e2e6c28e2729ad8ef0fd25f622ddc7f0fa456ce-PR-356Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matheus Marchini mmarchini@netflix.com