Adding CredentialsProvider to support vault like rotating credentials #6350
+637
−208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks to address #5745 by adding a CredentialsProvider which will rotate both Username and Password.
Thought about adding in only a "UsernameProvider" to rotate username and go along with the already existing password provider for rotation, but it felt that as Vault, and Aws Secrets Manager return both the user and pass in a single call, giving two actions that would execute felt less aligned.
If set things will call to the credentials provider first, otherwise it will fall back into what are the current methods etc.
Happy for any feedback or potential changes.
(much like the user that raised the issue, we use Vault at my company and many teams have built out the same workaround of just rebuilding the datasource)