Respect handleOrdinates also when writing geometry #6380
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the handleOrdinates configuration option to control which ordinates (coordinate dimensions) are written when serializing geometry objects, not just when reading them. Previously, this option only affected deserialization, which could lead to unexpected ordinates being written when NTS geometry processing introduces additional dimensions.
Key changes:
- Instantiate and configure a
PostGisWriterwith thehandleOrdinatessetting - Pass the configured writer to the mappings setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| TypeInfoMappingCollection? _mappings; | ||
| protected TypeInfoMappingCollection Mappings => _mappings ??= AddMappings(new(), _gisReader, new(), _geographyAsDefault); | ||
| protected TypeInfoMappingCollection Mappings => _mappings ??= AddMappings(new(), _gisReader, _gisWriter, _geographyAsDefault); |
There was a problem hiding this comment.
The _gisWriter field is used in the lazy initialization of Mappings, but _gisWriter is only initialized in the constructor. If Mappings is accessed before the constructor completes (e.g., in a derived class), this could result in using an uninitialized field. Consider ensuring the initialization order is safe or moving the writer initialization inline with the reader.
There was a problem hiding this comment.
I think it is the same for existing fields.
1 participant
This is a proposed fix for #6381.