Update .NET SDK to 10.0.101 and use MTP #6393
Open
+33
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
patch-1
branch
2 times, most recently
from
f558c0a to
130fb65
Compare
Youssef1313
commented
Dec 25, 2025
| run: | | ||
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} test/Npgsql.Tests --logger "GitHubActions;report-warnings=false" --blame-hang-timeout 30s | ||
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} test/Npgsql.DependencyInjection.Tests --logger "GitHubActions;report-warnings=false" | ||
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} --no-build --no-progress --project test/Npgsql.Tests --hangdump --hangdump-timeout 30s |
Author
There was a problem hiding this comment.
Note 1: GitHubActions logger of VSTest doesn't yet support MTP. Not sure if you consider the lack of it as a blocker. Alternatively, you can report TRX files and use https://github.com/marketplace/actions/publish-test-results instead.
Youssef1313
commented
Dec 25, 2025
Comment on lines
+304
to
+305
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} --no-build --no-progress --project test/Npgsql.Tests --hangdump --hangdump-timeout 30s | ||
| dotnet test -c ${{ matrix.config }} -f ${{ matrix.test_tfm }} --no-build --no-progress --project test/Npgsql.DependencyInjection.Tests |
Author
There was a problem hiding this comment.
Note 2: This is unrelated of my changes. But I'm not sure if this step will fail when the first command fails, or if it will only consider the last exit code.
There was a problem hiding this comment.
Pull request overview
This PR updates the .NET SDK from version 10.0.100 to 10.0.101 and migrates the test infrastructure from traditional test runners to the Microsoft Testing Platform (MTP).
Key Changes:
- Updated .NET SDK version to 10.0.101 in global.json and added MTP runner configuration
- Removed
Microsoft.NET.Test.Sdk,GitHubActionsTestLogger, andxunit.runner.visualstudiopackages - Added MTP-specific packages:
Microsoft.Testing.Extensions.HangDumpfor NUnit projects andYTest.MTP.XUnit2for xUnit projects - Configured test projects with
OutputType=Exeand enabled MTP properties in Directory.Build.props
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updated SDK version to 10.0.101 and configured Microsoft Testing Platform as the test runner |
| Directory.Packages.props | Removed traditional test packages (Microsoft.NET.Test.Sdk, xunit.runner.visualstudio, GitHubActionsTestLogger) and added MTP packages (Microsoft.Testing.Extensions.HangDump, YTest.MTP.XUnit2) |
| test/Directory.Build.props | Removed GitHubActionsTestLogger reference and added MTP-specific MSBuild properties (EnableNUnitRunner, UseMicrosoftTestingPlatformRunner) |
| test/Npgsql.Tests/Npgsql.Tests.csproj | Added OutputType=Exe property and Microsoft.Testing.Extensions.HangDump package for MTP support |
| test/Npgsql.Specification.Tests/Npgsql.Specification.Tests.csproj | Added OutputType=Exe property and replaced xunit.runner.visualstudio with YTest.MTP.XUnit2 adapter |
| test/Npgsql.PluginTests/Npgsql.PluginTests.csproj | Added OutputType=Exe property and removed Microsoft.NET.Test.Sdk package |
| test/Npgsql.DependencyInjection.Tests/Npgsql.DependencyInjection.Tests.csproj | Added OutputType=Exe property and removed Microsoft.NET.Test.Sdk package |
| test/Npgsql.NativeAotTests/Npgsql.NativeAotTests.csproj | Removed GitHubActionsTestLogger package reference exclusion |
| .github/workflows/build.yml | Updated test commands to use new MTP-specific flags (--hangdump, --hangdump-timeout) and added --no-build, --no-progress options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.