Skip to content

Conversation

@marc1706
Copy link
Member

@marc1706 marc1706 commented Oct 10, 2025

viewtopic on desktop:
image

viewtopic mobile view:
image

pm view on desktop:
image

pm view on mobile:
image

PHPBB-17566

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17566

@rxu
Copy link
Contributor

rxu commented Oct 11, 2025

Great, I thought this feature would be more complex to implement.
There's an issue though, it is possible in common to register usernames starting with a whitespace.
For example ( whitespaceusername), which would result in just colored circle then. Another variants are some non-letter symbols being 1st, like -, +, _, [, and ], but those are visible at least :)

@iMattPro
Copy link
Member

Great, I thought this feature would be more complex to implement. There's an issue though, it is possible in common to register usernames starting with a whitespace. For example ( whitespaceusername), which would result in just colored circle then. Another variants are some non-letter symbols being 1st, like -, +, _, [, and ], but those are visible at least :)

that makes me think we should not allow usernames to start with a white space?

@rxu
Copy link
Contributor

rxu commented Oct 12, 2025

we should not allow usernames to start with a white space

Easier way:

{{ USERNAME|striptags|trim(' -+_[]', 'left')|slice(0, 1)|upper }}

@marc1706 marc1706 requested a review from Derky December 23, 2025 10:42
@marc1706 marc1706 merged commit 97d4281 into phpbb:master Dec 23, 2025
35 checks passed
@marc1706 marc1706 deleted the ticket/17566 branch December 23, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants