[ticket/17591] Update CodeSniffer to v4-master version #6908
+130
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPBB-17591
phpBB/composer.lockDev Package changes
Settings · Docs · Powered by Private Packagist |
Member
Author
|
Tests do pass. Just CI-BS™ again. |
Contributor
|
Tested with EC 1.11.0-dev, CS 4.0.1, and PPSSE 4.x bc680bc. A developer provided me with an extension that had already been adapted for phpBB 4.0.0-a1. I used this extension to run the test with Ext Check, as this test suite automatically switches between PPSSE 3.x and 4.x. This allowed me to conduct a real-world test. Without the fix, PPSSE 4.x reported 14 false positives. With #6908, no false positives were reported. 👍 |
marc1706
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB-17591
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17591