Skip to content

Conversation

@hasansezertasan
Copy link
Contributor

Related to #698

Description

Move tox configuration to pyproject.toml file.

@hasansezertasan
Copy link
Contributor Author

I am not sure how to move tox-gh-actions specific configurations to pyproject.toml. Does anyone have an idea?


I also wonder, why do we need it? What would happen if we just didn't use it? I would be very happy if you can help me with this one @patkan 🫶.

Co-authored-by: Benito López <belono@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.39%. Comparing base (11d46fd) to head (983f935).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files          21       21           
  Lines        1693     1693           
  Branches      267      237   -30     
=======================================
  Hits         1378     1378           
  Misses        235      235           
  Partials       80       80           
Flag Coverage Δ
unittests 81.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Benito López <belono@users.noreply.github.com>
@hasansezertasan
Copy link
Contributor Author

I found this package called tox-gh, by the @tox-dev team. WDYT about using it instead of tox-gh-actions?

@hasansezertasan
Copy link
Contributor Author

hasansezertasan commented Sep 7, 2025

All checks are green now, let me know if any updates are required. @belono, and thank you for all the reviews 🙏.

@hasansezertasan hasansezertasan marked this pull request as ready for review September 7, 2025 22:04
Copy link
Contributor

@belono belono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to say but... great job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants