Skip to content

Conversation

@hasansezertasan
Copy link
Contributor

Related to #704

- Changed base image to use UV with Python 3.11.
- Updated working directory and file copying to align with UV requirements.
- Removed requirements.txt and replaced it with uv.lock and pyproject.toml for dependency management.
- Modified README to reflect new build and run commands.
- Set default command to run the application using UV.
… ESC/POS integration

- Added a new Flask application example in the `flask-example` directory.
- Implemented a simple printing functionality using `CupsPrinter`.
- Created a Dockerfile for building and running the application.
- Included `pyproject.toml` and `uv.lock` for dependency management.
- Updated README with build and run instructions.
@@ -1,11 +1,23 @@
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

@@ -1,9 +1,12 @@
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same on this file. We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

@@ -1,21 +1,26 @@
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here. We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

@@ -1,9 +1,21 @@
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too. We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

@@ -1,25 +1,38 @@
""" Example for software_columns: Print text arranged into columns."""
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here. We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

@@ -1,4 +1,9 @@
#!/usr/bin/python
# /// script
# requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same case. We should require the minimum version of Python we currently support, otherwise a user would not be able to run this example script on a version lower than 3.12 while we currently support Python >=3.9.

Suggested change
# requires-python = ">=3.12"
# requires-python = ">=3.9"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants