Add Config.load_yaml_string() #707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Elias0419, and thanks for your contribution. I like this feature and I'm glad you included tests with it. The code looks good, although I'd like to make a few suggestions. |
belono
reviewed
Sep 14, 2025
Contributor
belono
left a comment
belono
left a comment
There was a problem hiding this comment.
I think that's all for now.
Feel free to discuss any of my suggestions if you disagree or if I haven't expressed my point well 👌
belono
reviewed
Sep 14, 2025
belono
approved these changes
Sep 15, 2025
Contributor
belono
left a comment
belono
left a comment
There was a problem hiding this comment.
It's been a pleasure @Elias0419 .
Very good job!! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new method Config.load_yaml_string() to allow loading configuration directly from a YAML string.