Improve and extend the _read() method availability for its users and related methods. Part 1: Cupsprinter and on/offline.
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 81.39% 81.41% +0.02%
==========================================
Files 21 21
Lines 1693 1695 +2
Branches 267 267
==========================================
+ Hits 1378 1380 +2
+ Misses 235 234 -1
- Partials 80 81 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
belono
changed the title
_read() method availability for its users and related methods. Part 1: Cupsprinter and on/offline.
This was referenced Oct 4, 2025
Contributor
Author
|
Hey there @patkan . I know you've been short on time lately, but if you could take a look at these 4 requests and merge them, it would help me write the tests. 🙏 Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This starts a PR series to improve and extend the availability of the
_read()method to some connectors where it is currently not implemented.The objectives of this series are:
_read()method in the following connectors:File()Dummy()Part 1: Improve on/offline masks consistency and its usage by the Cups connector:
This will close #611 by:
RT_MASK_OFFLINEconstant and change the value ofRT_MASK_ONLINEto a value that is more consistent with the ESC/POS real-time status response format for both constants (a validator/checker is planned for a follow up PR). The new values are also consistent with the rest of RT_MASK_* constants._read()method in theCupsPrinter()connector to improve readability.Part 2: #711
Part 3: #712
Part 4: #714
Tested with
TM-U210 Parallel port printer