Skip to content

Fix incorrect obd src echo #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdb9696 merged 1 commit into from
Jan 3, 2025
Merged

Fix incorrect obd src echo #1412

sdb9696 merged 1 commit into from
Jan 3, 2025

Conversation

@rytilahti
Copy link
Member

@rytilahti rytilahti commented Jan 3, 2025

Fixes #1407

@rytilahti rytilahti added the bug Something isn't working label Jan 3, 2025
@codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (361697a) to head (59443e9).
Report is 79 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1412   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         132      132           
  Lines        8203     8203           
  Branches      839      839           
=======================================
  Hits         7582     7582           
  Misses        459      459           
  Partials      162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdb9696
sdb9696 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdb9696 sdb9696 merged commit 883d522 into master Jan 3, 2025
18 checks passed
@sdb9696 sdb9696 deleted the fix/incorrect_obd_src branch January 3, 2025 18:07
@sdb9696 sdb9696 mentioned this pull request Jan 6, 2025
Merged
sdb9696 added a commit that referenced this pull request Jan 6, 2025
@sdb9696
Prepare 0.9.1 (#1426)
40886ef 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\#1421](#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\#1414](#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\#1362](#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\#1409](#1409)
- Backoff after xor timeout and improve error reporting [\#1424](#1424) (@bdraco)
- Fix incorrect obd src echo [\#1412](#1412) (@rytilahti)
- Handle smartcam partial list responses [\#1411](#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\#1419](#1419) (@rytilahti)
- Add S210 fixture [\#1418](#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\#1417](#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\#1406](#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\#1405](#1405) (@ZeliardM)
- Change smartcam detection features to category config [\#1402](#1402) (@sdb9696)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@rytilahti
Fix incorrect obd src echo (python-kasa#1412)
8f53d2b
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@sdb9696 @rytilahti
Prepare 0.9.1 (python-kasa#1426)
2fcbf7e 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@rytilahti
Fix incorrect obd src echo (python-kasa#1412)
7a4856c
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@sdb9696 @rytilahti
Prepare 0.9.1 (python-kasa#1426)
ee2ce92 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@rytilahti
Fix incorrect obd src echo (python-kasa#1412)
ea989ca
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@sdb9696 @rytilahti
Prepare 0.9.1 (python-kasa#1426)
57a85f2 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdb9696 sdb9696 sdb9696 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ODB Src Mismatch

3 participants

@rytilahti @sdb9696