Add FeatureAttributes to smartcam Alarm #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 92.63% 92.64% +0.01%
==========================================
Files 149 149
Lines 9434 9439 +5
Branches 958 958
==========================================
+ Hits 8739 8745 +6
+ Misses 498 496 -2
- Partials 197 198 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdb9696
commented
Jan 29, 2025
sdb9696
commented
Jan 29, 2025
| """ | ||
|
|
||
| async def _async_wrap(self: _T, *args: _P.args, **kwargs: _P.kwargs) -> dict: | ||
| @wraps(func) |
Collaborator
Author
There was a problem hiding this comment.
This was previously not working when using a decorator which the test cases highlighted. i.e. if using a decorator the type hints were not copied to the decorator function so get_feature would fail.
rytilahti
approved these changes
Jan 29, 2025
Member
rytilahti
left a comment
rytilahti
left a comment
There was a problem hiding this comment.
Just a couple of readability nits, feel free to fix/merge as you wish.
Co-authored-by: Teemu R. <tpr@iki.fi>
Merged
sdb9696
added a commit
that referenced
this pull request
Feb 2, 2025
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\#1488](#1488) (@rytilahti) - Add Dimmer Configuration Support [\#1484](#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\#1491](#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\#1489](#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\#1478](#1478) (@sdb9696)
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Aug 31, 2025
Co-authored-by: Teemu R. <tpr@iki.fi>
rytilahti
pushed a commit
to rytilahti/python-kasa
that referenced
this pull request
Aug 31, 2025
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti) - Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Oct 26, 2025
Co-authored-by: Teemu R. <tpr@iki.fi>
rytilahti
pushed a commit
to rytilahti/python-kasa
that referenced
this pull request
Oct 26, 2025
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti) - Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Nov 10, 2025
Co-authored-by: Teemu R. <tpr@iki.fi>
rytilahti
pushed a commit
to rytilahti/python-kasa
that referenced
this pull request
Nov 10, 2025
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti) - Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missed off in #1479. Testing with HA PR 136642 picked this up.
Adding a test case for this highlighted that the decorators currently lose the
Annotatedannotations whichfunctools.wrapsfixes.