Add python 3.14 to supported versions #1599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
commented
Nov 28, 2025
Comment on lines
+14
to
+16
| install: | ||
| - pip install --upgrade pip | ||
| - pip install --group 'docs' |
Member
Author
There was a problem hiding this comment.
Necessary as pyproject.toml uses now standard dependecy groups.
|
|
||
| async def invoke_subcommand( | ||
| command: click.BaseCommand, | ||
| command: click.Command, |
Member
Author
There was a problem hiding this comment.
Spotted by mypy, BaseCommand is deprecated with this message
"'BaseCommand' is deprecated and will be removed in Click 9.0. Use"
" 'Command' instead."
Comment on lines
+746
to
+747
| if device_type is None: | ||
| raise UnsupportedDeviceError("type nor mic_type found in sysinfo response") |
Member
Author
There was a problem hiding this comment.
Unsure why this was not spotted earlier by mypy, but from_values below expects that this is not none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.