-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
status-subscription - Restore feature
#8790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
status-subscription - Restore feature
#8790
Conversation
|
Is there is a way to obtain pr subscription state via api? |
No, that's the issue 🥲 |
| } | ||
|
|
||
| const body = { | ||
| query: 'dd170c659a085a45885ee5a168fc52c8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this is a generated ID and it might break on the next deployment. Let's wait a week or two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this is a generated ID
Yes
Let's wait a week or two.
Absolutely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works - the hash hasn't changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash has changed, but the server doesn't reject the request with an outdated hash
Co-authored-by: fregante <me@fregante.com>
|
|
||
| async function addButtonIssue(subscriptionButton: HTMLButtonElement): Promise<void> { | ||
| const status = await getCurrentStatusIssue(); | ||
| const previousRghButton = $optional('.rgh-status-subscription', subscriptionButton.parentElement!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to update the state?
| const {id} = issue.repository.issue; | ||
|
|
||
| const body = { | ||
| query: 'd0752b2e49295017f67c84f21bfe41a3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hash seems to be quite stable
I don't really expect this to be merged
Fixes #7968
Test URLs
#8785
Screenshot