Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Dec 18, 2025

Sg312 and others added 13 commits December 18, 2025 09:57
…state, fix order of operations for copilot edit workflow, add sleep tool (#2440)

* Fix copilot ooo

* Add copilot sleep tool

* Fix lint
* fix(condition): async execution isolated vm error

* fix tests
…ed confirmation for disable auth FF (#2447)

* fix(auth): added same-origin validation to forget password route, added confirmation for disable auth FF

* ack PR comments
…of sync with migrations (#2449)

* feat(compare-schema): ci check to make sure schema.ts never goes out of sync with migrations

* test out of sync [do not merge]

* Revert "test out of sync [do not merge]"

This reverts commit 9771f66.
…enerateurl function when the useWebhookurl flag is true
…n, developer, and custom domain salesforce orgs (#2441) (#2444)

* fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records (#2441)

* fix(oauth): updated oauth providers that had unstable reference IDs leading to duplicate oauth records

* ack PR comments

* ack PR comments

* cleanup salesforce refresh logic

* ack more PR comments
* feat(docs): added 404 page for the docs

* added metadata
…ookUrl-conditioning

improvement(useWebhookUrl): GET api/webhook is called when useWebhookUrl:true
…roduction, developer, and custom domain salesforce orgs (#2441) (#2444)" (#2453)

This reverts commit 9da19e8.
…inor consistency issue with filter parsing (#2452)

* fix(notifs-slac): display name for account

* fix inactivity polling check

* consolidate trigger types

* remove redundant defaults

* fix
…ts (#2454)

* improvement(helm): added SSO and cloud storage variables to helm charts

* consolidated sf types
@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 18, 2025 11:58pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 18, 2025

Greptile Summary

  • Implements comprehensive fixes for copilot state management and adds sleep tool functionality, addressing critical issues where copilot could set undefined workflow state and order-of-operations problems in workflow editing
  • Consolidates Salesforce tool type definitions into centralized types.ts file and adds comprehensive notification filtering improvements, including same-origin validation for password reset security
  • Enhances Helm chart configuration with SSO and cloud storage variables for AWS S3 and Azure Blob, plus adds CI schema validation to prevent migration drift

Important Files Changed

Filename Overview
apps/sim/lib/workflows/diff/diff-engine.ts Added critical validation to prevent invalid block IDs from corrupting workflow state
apps/sim/lib/copilot/tools/server/workflow/edit-workflow.ts Fixed order of operations for copilot workflow editing with two-pass processing and block ID validation
apps/sim/tools/salesforce/types.ts Centralized Salesforce tool type definitions to reduce duplication and improve maintainability
apps/sim/executor/handlers/condition/condition-handler.ts Replaced isolated VM execution with tool execution to fix async execution errors
apps/sim/app/api/auth/forget-password/route.ts Added same-origin validation to prevent open redirect vulnerabilities

Confidence score: 4/5

  • This PR requires careful review due to complex copilot state management changes and security fixes
  • Score reflects the critical nature of workflow state corruption prevention and the extensive refactoring across multiple Salesforce tool files
  • Pay close attention to the diff engine validation logic and copilot editing order of operations fixes

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. apps/sim/tools/salesforce/get_accounts.ts, line 68-94 (link)

    style: complex JWT decoding logic is duplicated - consider using the imported getInstanceUrl utility

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  2. apps/sim/tools/salesforce/create_account.ts, line 125-157 (link)

    style: Complex inline instance URL extraction duplicates the imported getInstanceUrl utility function. Should this logic use the imported getInstanceUrl utility instead?

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

66 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

CodeLoopdroid and others added 2 commits December 18, 2025 14:57
* fix(docs): clarify working directory for drizzle migration (#2375)

* fix(landing): prevent url encoding for spaces for footer links (#2376)

* fix: handle empty body.value in Teams webhook notification parser (#2425)

* Update directory path for migration command

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Waleed <walif6@gmail.com>
Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com>
Co-authored-by: icecrasher321 <icecrasher321@users.noreply.github.com>
Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com>
Co-authored-by: mosa <mosaxiv@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com>
Co-authored-by: Shivam <shivamprajapati035@gmail.com>
Co-authored-by: Gaurav Chadha <65453826+Chadha93@users.noreply.github.com>
Co-authored-by: root <root@Delta.localdomain>
…flow (#2448)

* Add edge handle validation

* Clean

* Fix lint

* Fix empty target handle
Co-authored-by: priyanshu.solanki <priyanshu.solanki@saviynt.com>
@waleedlatif1 waleedlatif1 changed the title v0.5.35: helm updates, copilot improvements, 404 for docs, salesforce fixes v0.5.35: helm updates, copilot improvements, 404 for docs, salesforce fixes, subflow resize clamping Dec 19, 2025
@icecrasher321 icecrasher321 merged commit eb07a08 into main Dec 19, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants