-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(tools): improved slack output ux and jira params #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR enhances Jira and Slack tool functionality with improved UX and expanded capabilities. Slack Improvements:
Jira Enhancements:
UI/UX:
Documentation:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UI as Workflow Editor
participant JiraWrite as Jira Write API
participant JiraAPI as Jira API
participant SlackTool as Slack Tools
Note over User,SlackTool: Slack UX Improvements
User->>SlackTool: Call list_channels/list_users
SlackTool->>SlackTool: Map channels/users to extract ids and names
SlackTool-->>User: Return {channels, ids, names, count}
User->>UI: Select from dropdown using ids/names arrays
Note over User,JiraAPI: Jira Write Enhancements
User->>UI: Create Jira issue with new fields
UI->>JiraWrite: POST with labels, duedate, reporter, etc.
JiraWrite->>JiraWrite: Validate and transform fields
JiraWrite->>JiraWrite: Handle priority (detect ID vs name)
JiraWrite->>JiraWrite: Format environment as ADF document
JiraWrite->>JiraWrite: Process custom field ID format
JiraWrite->>JiraAPI: POST /issue (create without assignee)
JiraAPI-->>JiraWrite: Return {key, fields}
alt Assignee provided
JiraWrite->>JiraAPI: PUT /issue/{key}/assignee
JiraAPI-->>JiraWrite: 204 No Content
end
JiraWrite-->>User: Return {issueKey, url, assigneeId}
Note over User,JiraAPI: New Get Users Operation
User->>JiraWrite: Request jira_get_users
JiraWrite->>JiraAPI: GET /users/search?startAt&maxResults
JiraAPI-->>JiraWrite: Return user array
JiraWrite-->>User: Return {users, total, startAt, maxResults}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 files reviewed, 1 comment
apps/sim/blocks/blocks/jira.ts
Outdated
| id: 'customFieldValue', | ||
| title: 'Team UUID', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Misleading title for generic custom field parameter
| id: 'customFieldValue', | |
| title: 'Team UUID', | |
| title: 'Custom Field Value', |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/blocks/blocks/jira.ts
Line: 256:257
Comment:
**style:** Misleading title for generic custom field parameter
```suggestion
title: 'Custom Field Value',
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Summary
Improved both slack output and jira params for tools. Added one more jira operation
Type of Change
Testing
Manually
Checklist