Skip to content

Conversation

@aadamgough
Copy link
Collaborator

Summary

Added UUID for customfield

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 22, 2025 5:59am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 22, 2025

Greptile Summary

Reverted the specialized teamUuid parameter back to the generic customFieldValue parameter in the Jira block configuration

Changes made:

  • Removed the teamUuid sub-block definition (lines 255-262)
  • Kept the existing customFieldValue sub-block with updated naming
  • Updated the params function logic to use params.customFieldValue directly instead of the fallback chain params.teamUuid || params.customFieldValue
  • Removed the teamUuid input definition from the inputs schema

Impact:
The change simplifies the Jira block by removing the specialized teamUuid field and relying on the more generic customFieldValue field that already existed. This maintains consistency with the existing custom field pattern where users provide both customFieldId and customFieldValue for any custom field, rather than having specialized fields for specific custom field types.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple refactoring that removes a specialized parameter in favor of using the existing generic parameter. The implementation is clean and consistent with the existing codebase patterns. All references to teamUuid have been properly removed, and the fallback logic has been simplified to use only customFieldValue. The change maintains backward compatibility since the functionality remains the same - users can still set custom field values using the customFieldValue parameter.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/jira.ts Renamed teamUuid field to customFieldValue to properly represent generic custom field functionality

Sequence Diagram

sequenceDiagram
    participant User
    participant JiraBlock
    participant ParamsConfig
    participant JiraWriteTool
    participant JiraAPI
    
    User->>JiraBlock: Select Write Issue operation
    User->>JiraBlock: Enter customFieldValue
    JiraBlock->>ParamsConfig: Process params (operation: write)
    ParamsConfig->>ParamsConfig: Extract customFieldValue from params
    ParamsConfig->>ParamsConfig: Build writeParams object
    ParamsConfig->>JiraWriteTool: Pass customFieldValue parameter
    JiraWriteTool->>JiraAPI: POST /api/tools/jira/write
    Note over JiraAPI: Validates customFieldId and customFieldValue
    JiraAPI->>JiraAPI: Add custom field to issue fields
    JiraAPI->>JiraAPI: Create Jira issue with custom field
    JiraAPI-->>JiraWriteTool: Return issue details
    JiraWriteTool-->>User: Display created issue
Loading

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 22, 2025

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

@aadamgough aadamgough merged commit 58fcb4e into staging Dec 22, 2025
11 checks passed
@aadamgough aadamgough deleted the fix/jira branch December 22, 2025 06:04
waleedlatif1 pushed a commit that referenced this pull request Dec 22, 2025
* added uuid param

* revmoed comment

* fixed naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants