chore(logs): add verbose logging for batch changes steps #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add detailed verbose logging to stepsExecTUI for batch changes execution. When -v flag is passed, users now see logs for: - Archive download start/completion/failure - Workspace initialization - Step caching (skipped steps) - Step preparation and execution - Step completion with diff size and file change counts - Step failures with exit codes
Add verbose logging to TUI for batch changes pre-execution steps: - Namespace resolution: show resolved namespace ID - Container images: log successful preparation - Workspace resolution: show workspace/repo counts and unsupported/ignored counts - Cache check: show cached specs and tasks to execute
bahrmichael
approved these changes
Dec 11, 2025
burmudar
reviewed
Dec 12, 2025
| switch startStep { | ||
| case 1: | ||
| ui.updateStatusBar("Skipping step 1. Found cached result.") | ||
| ui.out.Verbosef("[%s] Skipping step 1 (cached result found)", ui.task.Repository.Name) |
Contributor
There was a problem hiding this comment.
Won't we have duplicate output when using -v?
[ Skipping step 1. Found cached result. ]
[sourcegraph/sourcegraph] Skipping step 1 (cached result found)
or can you provide a screenshot of how this looks? with and without the verbose flag
Contributor
Author
There was a problem hiding this comment.
Yes, however, the statusbar text changes depending on the steps so the text isn't preserved for one to see if they aren't looking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
-vto true didn't include information that can be used for debugging. This PR improves that adding detailed logging to several points of the Batch Changes pre-execution and execution steps.Closes CP-4
Test plan
Manually running a batch spec with the
src-cli.