Skip to content

Added PostgreSQL v13 VACUUM PARALLEL option support #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
guptapratykshh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added PostgreSQL v13 VACUUM PARALLEL option support #1208

guptapratykshh wants to merge 3 commits into from

Conversation

@guptapratykshh
Copy link

@guptapratykshh guptapratykshh commented Apr 5, 2025 •
edited
Loading

This PR adds support for the PARALLEL option of VACUUM commands in PostgreSQL 13+. The PARALLEL option was introduced in PostgreSQL 13 and allows specifying number of parallel worker processes to use when running a parallel vacuum operation.

image

@guptapratykshh
Copy link
Author

guptapratykshh commented Apr 6, 2025

@robins @mrigger please look into this support that i added for PostgreSQL v13. Please review it.

@guptapratykshh
Copy link
Author

guptapratykshh commented Apr 7, 2025

Can you please look into this PR @robins @mrigger

@robins
Copy link
Collaborator

robins commented Apr 8, 2025

@guptapratykshh - A few things.

  1. We don't want to go the route of server_version_num here. The goal is that ideally SQLancer doesn't need to check the version and should support all commands in the existing / supported version - See this discussion - (as discussed here) .

  2. The PR [Postgres][v13] Skip errors around VACUUM FULL not supporting PARALLEL #1053 seems to be on similar lines, and is waiting for v13 support to go live.

  3. I think the intention of this PR, to restrict PARALLEL count is understandable, but sometimes restricting search space goes against what the tool is trying to do - in effect that number is intentionally left unrestricted so that if it (negative or very large int) triggers the engine to go wild, then so be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guptapratykshh @robins