Skip to content

Add the SQLQueryError class for DQE and its test #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrigger merged 4 commits into from
Jul 20, 2025
Merged

Add the SQLQueryError class for DQE and its test #1257

mrigger merged 4 commits into from
Jul 20, 2025

Conversation

@luliqwerty
Copy link
Contributor

@luliqwerty luliqwerty commented Jul 9, 2025 •
edited
Loading

This PR is used to split #1251 into small pieces.

The core idea of DQE is that the SELECT, UPDATE and DELETE queries with the same predicate φ should access the same rows. If these queries access different rows, DQE reveals a potential logic bug in the target DBMS. SQLQueryError class is used to compare the errors @mrigger @JensonSung

@luliqwert
Add the SQLQueryError class for DQE and its test
0cc62d2 
The core idea of DQE is that the SELECT, UPDATE
and DELETE queries with the same predicate φ
should access the same rows.
If these queries access different rows,
DQE reveals a potential logic bug in the target DBMS.

SQLQueryError class is used to compare the errors
@luliqwerty luliqwerty mentioned this pull request Jul 9, 2025
Merged
@JensonSung
Copy link
Contributor

JensonSung commented Jul 9, 2025

Looks good to me.

mrigger
mrigger reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - I have been traveling. This almost looks good to me. Could you please check whether any of my suggestions make sense before merging this?

mrigger
mrigger approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mrigger
Copy link
Contributor

mrigger commented Jul 16, 2025

It seems the formatter check currently fails. After executing mvn formatter:format, we can merge the PR.

@luliqwerty
Copy link
Contributor Author

luliqwerty commented Jul 16, 2025

It seems the formatter check currently fails. After executing mvn formatter:format, we can merge the PR.

I'm sorry for that mistakes, I've solved that. Thanks a lot. @mrigger

@mrigger
Copy link
Contributor

mrigger commented Jul 16, 2025

It seems some code style checks fail. You can execute mvn -B verify -DskipTests=true locally to check and resolve them.

@luliqwerty
Copy link
Contributor Author

luliqwerty commented Jul 16, 2025 •
edited
Loading

It seems some code style checks fail. You can execute mvn -B verify -DskipTests=true locally to check and resolve them.

I hava get the BUIDE SUCESS locally. Thanks a lot. @mrigger

@mrigger mrigger merged commit a407481 into sqlancer:main Jul 20, 2025
17 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrigger mrigger mrigger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luliqwerty @JensonSung @mrigger @luliqwert