Quality improvements #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderer
force-pushed
the
quality-of-life
branch
from
e05e0ef to
8626e69
Compare
…, dropped HHVM as PHPUnit no longer works on it, added Makefile with multiple PHP version composer update and phpunit commands, added docker-compose with from PHP 5.4 up to 7.3 (5.4 from custom Dockerfile, 5.3 is not available due to lack of the mbstring extension), added hirak/prestissimo for faster dependency installation, fixed phpunit.xml issues reported with the latest version, resolved the issue with expectException() on PHP 7.3
thunderer
force-pushed
the
quality-of-life
branch
from
bea5f34 to
9e653b8
Compare
…function calls, strict comparison
thunderer
force-pushed
the
quality-of-life
branch
from
9e653b8 to
66cc3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-composewith PHP from 5.4 up to 7.3 (custom 5.4 image, 5.3 lacksext-mbstring),composer updateandphpunitcommands based ondocker-compose,hirak/prestissimofor faster dependency installation,expectException()on PHP 7.3,phpunit.xmlissues.