Skip to content

Conversation

@ericjang
Copy link
Contributor

I'm new to poetry workflows, and noticed that the test suite assumes two environment variables are set.

By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?

I'm new to poetry workflows, and noticed that the test suite assumes two environment variables are set. 

By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?
@ErikBjare
Copy link
Member

Thanks for the contributions and the shoutout on Twitter!

By the way, is there any particular reason why MAINNET_PROVIDER and PROVIDER can't be consolidated into a single variable?

There used to be, but there isn't really anymore. I'll push changes to fix this in a couple min.

@ErikBjare ErikBjare changed the title Add additional test instructions to README docs: add additional test instructions to README May 31, 2021
@ErikBjare ErikBjare merged commit 6af0f28 into uniswap-python:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants