Skip to content

Conversation

@liquid-8
Copy link
Member

Closes #125
DAI has been rebranded to SAI (https://blog.makerdao.com/looking-ahead-how-to-upgrade-to-multi-collateral-dai/) so old variable names and descriptions are kinda confusing.

DAI has been rebranded to SAI (https://blog.makerdao.com/looking-ahead-how-to-upgrade-to-multi-collateral-dai/) so old variable names and descriptions are kinda confusing.
@ErikBjare
Copy link
Member

ErikBjare commented Jul 12, 2021

Maybe it would be better to change the example to use the new DAI contract?

@liquid-8
Copy link
Member Author

You're right. Fixed that.

@ErikBjare ErikBjare merged commit 263619d into uniswap-python:master Jul 14, 2021
@liquid-8 liquid-8 deleted the patch-1 branch October 19, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API docs have SAI address instead of DAI in an example

2 participants