Fix v3 behaviour when input or output token is ETH #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanbsd
reviewed
Aug 24, 2021
Contributor
|
Cool! I didn't get to do it, and it's pretty much what I had in mind! |
romanbsd
reviewed
Sep 14, 2021
| slippage = self.default_slippage | ||
|
|
||
| if input_token == output_token: | ||
| raise ValueError |
Contributor
There was a problem hiding this comment.
maybe assert input_token != output_token is better?
ErikBjare
reviewed
Sep 17, 2021
Member
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Sorry for the delay. Ran tests locally and works well!
A couple of unrelated tests failed, but that's my bad, and they're not testing anything important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Uniswap v3 behaviour when ETH is the input or output token, resolving issues #154 and #155. There has also been some general tidying-up of parts of the code. Basic tests for all v3 scenarios have been run, but it would be good to check edge cases and verify that v1 and v2 still work as expected.