feat: price impact excludes fees #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ErikBjare just wanted to bring this PR to your attention again |
ErikBjare
approved these changes
Jun 22, 2023
uniswap/util.py
Outdated
| def fee_to_fraction(fee:int): | ||
| return fee / 1000000 | ||
|
|
||
| def fraction_to_fee(fraction:float): |
Contributor
Author
|
Hey @ErikBjare removed the function and formatted with black 👍 |
Contributor
Author
|
@ErikBjare just wanted to bring this PR to your attention again |
Member
|
Very nice, thanks for the ping! |
Member
|
And thanks for contributing! ❤️ |
Contributor
Author
|
Glad to have helped! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in: #310