Skip to content

Conversation

@kilink
Copy link
Contributor

@kilink kilink commented Jan 24, 2025

Make CoercedVariables.emptyVariables() and RawVariables.emptyVariables() return an immutable singleton instance.

Make CoercedVariables.emptyVariables() and RawVariables.emptyVariables() return an immutable singleton instance.
@kilink kilink force-pushed the coerced-variables-empty-singleton branch from 5b0c192 to 3d533da Compare January 24, 2025 19:50
@kilink kilink changed the title Return a singleton from CoercedVariables.emptyVariables Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables Jan 24, 2025
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@dondonz dondonz added the performance work that is primarily targeted as performance improvements label Jan 25, 2025
@dondonz dondonz added this to the 23.x breaking changes milestone Jan 25, 2025
@dondonz dondonz merged commit db35370 into graphql-java:master Jan 27, 2025
1 check passed
@kilink kilink deleted the coerced-variables-empty-singleton branch October 23, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance work that is primarily targeted as performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants