Skip to content

make DataFetcherResult jspecify better #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andimarek merged 3 commits into from
Nov 5, 2025
Merged

make DataFetcherResult jspecify better #4141

andimarek merged 3 commits into from
Nov 5, 2025
+10 −10

Conversation

@andimarek
Copy link
Member

@andimarek andimarek commented Oct 15, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 24c3453.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025 •
edited
Loading

Test Results

  326 files  + 1    326 suites  +1   5m 7s ⏱️ ±0s
5 218 tests +16  5 209 ✅ +15  9 💤 +1  0 ❌ ±0 
5 307 runs  +16  5 298 ✅ +15  9 💤 +1  0 ❌ ±0 

Results for commit 86419f9. ± Comparison against base commit fd372ae.

This pull request removes 213 and adds 205 tests. Note that renamed tests count towards both. 
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@4a29f290 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@4bee18dc delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@44f3fe83 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@24a298a6 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@982bb90 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@27f74733 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@7fedfe27 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@bdecc21 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@66bfd864 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@68809cc7 delegate=graphql.AssertTest@1d4664d7 owner=graphql.AssertTest@1d4664d7 thisObject=graphql.AssertTest@1d4664d7 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0]
…
This pull request skips 1 test. 
graphql.schema.fetching.LambdaFetchingSupportTest ‑ different class loaders induce certain behaviours

♻️ This comment has been updated with latest results.

@dondonz dondonz added this to the 25.x breaking changes milestone Oct 29, 2025
@andimarek andimarek merged commit 71e6199 into master Nov 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.x breaking changes

Development

Successfully merging this pull request may close these issues.

4 participants

@andimarek @bbakerman @dondonz