Skip to content

Conversation

@marilynel
Copy link
Contributor

@stleary
Copy link
Owner

stleary commented Apr 7, 2025

What problem does this code solve?
Fixes an inconsistency in how keepStrings is handled. For example, if keepStrings was set, the keepStrings flag was not set.
The new behavior is:

  • If keepStrings is set, the keepStrings, keepBooleanAsString, and keepNumberAsString flags will be set accordingly.
  • If either keepBooleanAsString or keepNumberAsString is set, then keepStrings will be set accordingly.
    Internally, there is no change to the existing behavior.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window.

@stleary stleary merged commit 8e65eaa into stleary:master Apr 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants